Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several ContentView test fixes #16486

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Several ContentView test fixes #16486

merged 4 commits into from
Sep 25, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Sep 25, 2024 •
edited
Loading

Problem Statement

Several CV tests are failing for various reasons:

  1. Ostree cases used to be skipped since hooked on a CLOSED_WONT_FIX BZ. The skip_if_open has been removed here
  2. Repo removal test cases are failing for a long time with key error since the file-repositories nor yum-repositories are returned by hammer if there are no repos to be listed.
  3. sat.cli.version_incremental_update(output_format='csv') does not return anything when CSV format is requested since there is nothing to be listed in that format.
  4. CV versions listing changed. There was an old sorting issue which was fixed but affected test cases were not.

Solution

  1. I had to choose if to stub or remove the Ostree cases. Decided to stub them since there still is some support for them in upstream.
  2. Just assert the fields are not listed after repo removal.
  3. Decided to default to the base output format since that returns at least the CV version. The assertion in test_positive_inc_update_no_lce was done above an empty list, that's why it passed anyway.
  4. Use sorted to get the latest CV version.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'rh_content_removed or file_repo_removal or e_inc_update'

trigger: test-robottelo
pytest: tests/foreman/cli/test_docker.py -k name_change_after_promotion

@vsedmik
Stub ostree test classes
edfb85f 
Ostree is unsupported since 6.10 and these classes were marked to
skip_if_open("BZ:2122780"), which was removed by SatelliteQE#16347.
So we can either stub them or remove completely.
@vsedmik
Fix repo_removal test cases
bda8814
@vsedmik
Default to 'base' for CVV incremental_update
8a97ec2 
Since there is no CSV returned by the incremental_update anyway.
@vsedmik
Fix out of order promotion of a CV version
6d811ac 
By promotion of the latest version.
@vsedmik vsedmik added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 labels Sep 25, 2024
@vsedmik vsedmik self-assigned this Sep 25, 2024
@vsedmik vsedmik requested review from a team as code owners September 25, 2024 09:13
@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 25, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'rh_content_removed or file_repo_removal or e_inc_update'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8789
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py -k rh_content_removed or file_repo_removal or e_inc_update --external-logging
Test Result : ========= 4 passed, 114 deselected, 147 warnings in 800.90s (0:13:20) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 25, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 25, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_docker.py -k name_change_after_promotion

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8793
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_docker.py -k name_change_after_promotion --external-logging
Test Result : ========== 2 passed, 48 deselected, 77 warnings in 751.20s (0:12:31) ===========

@pondrejk pondrejk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Sep 25, 2024
@pondrejk pondrejk merged commit 88e5aa0 into SatelliteQE:master Sep 25, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
@vsedmik @web-flow
Several ContentView test fixes (#16486)
6f92602 
* Stub ostree test classes

Ostree is unsupported since 6.10 and these classes were marked to
skip_if_open("BZ:2122780"), which was removed by #16347.
So we can either stub them or remove completely.

* Fix repo_removal test cases

* Default to 'base' for CVV incremental_update

Since there is no CSV returned by the incremental_update anyway.

* Fix out of order promotion of a CV version

By promotion of the latest version.

(cherry picked from commit 88e5aa0)
@Satellite-QE Satellite-QE mentioned this pull request Sep 25, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Several ContentView test fixes (SatelliteQE#16486)
931a703 
* Stub ostree test classes

Ostree is unsupported since 6.10 and these classes were marked to
skip_if_open("BZ:2122780"), which was removed by SatelliteQE#16347.
So we can either stub them or remove completely.

* Fix repo_removal test cases

* Default to 'base' for CVV incremental_update

Since there is no CSV returned by the incremental_update anyway.

* Fix out of order promotion of a CV version

By promotion of the latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysawant vijaysawant vijaysawant approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @Satellite-QE @pondrejk @vijaysawant